[darcs-devel] darcs patch: unset default author environment variabl... (and 3 more)

[David Roundy]

On Sun, Aug 06, 2006 at 01:30:08PM +0200, ptp at lysator.liu.se wrote:
> The first of these patches is only a proposal, as discussed
> briefly by me and David on debian-devel earlier.

These changes look good to me, on a first reading.

> Sat Aug  5 17:12:10 CEST 2006  Tommy Pettersson <ptp at lysator.liu.se>
>   * unset default author environment variables in test suite harness
>   This makes it harder to accidently write tests that fail because no author
>   is set.
> 
> Sun Aug  6 12:30:33 CEST 2006  Tommy Pettersson <ptp at lysator.liu.se>
>   * add test that replace with spaces fail
> 
> Sun Aug  6 12:42:15 CEST 2006  Tommy Pettersson <ptp at lysator.liu.se>
>   * fix negation of result in test
>   Negation with ! "uses" the result and thus there is no "failure", so the
>   script wouldn't have exit with failure.
> 
> Sun Aug  6 13:08:07 CEST 2006  Tommy Pettersson <ptp at lysator.liu.se>
>   * fail if replace token pattern contains spaces (issue231)
>   It would otherwise create a badly formated patch in pending with unexpected
>   results for subsequent commands.
-- 
David Roundy