[darcs-devel] darcs patch: Account for timezone offset in cleanDate... (and 1 more)

Eric Kow eric.kow at gmail.com
Sat Aug 12 03:52:54 PDT 2006


This is a followup to discussion on issue220.

Somewhat following Juliusz's suggestions, it splits the cleanDate/readDate
stuff into variants for user interface dates, new on-disk patch dates and old
on-disk patch dates.

Sat Jun 10 21:30:49 CEST 2006  Eric Kow <eric.kow at gmail.com>
  * Account for timezone offset in cleanDate  (Fixes issue173).
  

Sat Aug 12 12:20:34 CEST 2006  Eric Kow <eric.kow at gmail.com>
  * Be explicit about timezone handling (issue220); assume local by default.
  
  Except for the local timezone in the user interface, this patch is not
  expected to change darcs's behaviour.  It merely makes current practice
  explicit:
  
  - Assume local timezone when parsing date strings from the user
    interface (previous behaviour was assuming UTC).
  
  - Assume UTC timezone when parsing date strings from PatchInfo.
    Newer patch date strings do *not* specify the timezone, so it
    would be prudent to treat these as UTC.
   
  - Disregard timezone information altogether when reading patch
    dates (issue220).  Note that this bug was not caused by assuming local
    timezone, because legacy patch date strings explicitly tell you what
    the timezone to use.  The bug was caused by a patch that fixed
    issue173 by using timezone information correctly.  To preserve
    backwards-compatability, we deliberatly replicate the incorrect
    behaviour of overriding the timezone with UTC.
    (PatchInfo.make_filename)
   

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: text/x-darcs-patch
Size: 48138 bytes
Desc: A darcs patch for your repository!
Url : http://lists.osuosl.org/pipermail/darcs-devel/attachments/20060812/e3f66caa/attachment.bin


More information about the darcs-devel mailing list