[darcs-devel] darcs patch: Add "--[no-]check-patch" option and "checkpatch" pref ...

[Tommy Pettersson]

On Mon, May 15, 2006 at 01:17:51AM +0200, Juliusz Chroboczek wrote:
> Tony, could you please resubmit this patch without the code for
> checking the pref?  It's not needed, as Darcs will already accept a
> line of the form
> 
>   ALL check-patch=foo
> 
> or
> 
>   record check-patch=foo
> 
> in prefs/defaults and do the right thing.

It's a bit strange that --test and --check-patch behaves
slightly different. Test sets its command in prefs and turns it
on and off with --test / --no-test. Checkpatch _can_ set its
command in prefs and turns it off with --no-check-patch, but it
can't be turned on with --check-patch without also supplying a
command (that overrides prefs).

Wouldn't it be better to make --checkpatch do as --test?


-- 
Tommy Pettersson <ptp at lysator.liu.se>