[darcs-devel] darcs patch: add test for reverting removed directory (and 5 more)

David Roundy droundy at darcs.net
Sun Dec 10 15:50:12 PST 2006


This patch adds one more change, which is to not import HopefullyPrivate
anywhere, so that we now know it's certainly private.  This means I can
(and have started to) add extra "hidden" information in the Hopefully data
structure, in particular the hash of a given patch.  When the patch is
commuted, this hash is lost, which is precisely what we want.  There's no
way that code that isn't buggy already could end up with an invalid hash
this way, although sometimes we'll lose a hash that is still valid, due to
a trivial commute.

Anyhow, it's a pretty small and good change.  My only reservation is that I
ended up using pattern guards in one file, which required -fglasgow-exts.
But we're pretty ghc-specific anyways, and when Haskell' comes out we can
reevaluate our language level.

David

Wed Nov  8 12:23:44 PST 2006  Tommy Pettersson <ptp at lysator.liu.se>
  * add test for reverting removed directory

Sat Dec  9 14:39:16 PST 2006  David Roundy <droundy at darcs.net>
  * fix pending bug that broke several_commands.sh.

Sun Dec 10 13:18:46 PST 2006  David Roundy <droundy at darcs.net>
  * resolve conflict in white space.

Sun Dec 10 13:35:36 PST 2006  David Roundy <droundy at darcs.net>
  * change Maybe Patch to Hopefully Patch.
  This rather pervasive change move us to using a new Hopefully type, which
  is similar to Either String for storing patches that may or may not exist.
  This should improve error reporting.  At a minimum it'll making easier to
  improve error reporting.

Sun Dec 10 15:16:23 PST 2006  David Roundy <droundy at darcs.net>
  * don't use HopefullyPrivate outside of Hopefully.
  The idea is to hide the Hopefully constructors, so I can hide some more
  information in there, if I like, which should be handy for the hashed
  inventories, and may also come in handy (for similar reasons) with git
  repositories.

Sun Dec 10 15:44:53 PST 2006  David Roundy <droundy at darcs.net>
  * fix bug in haskell_policy check for HopefullyPrivate.
  Perhaps with this test, we can rename it to CertainlyPrivate?  :)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: text/x-darcs-patch
Size: 123234 bytes
Desc: A darcs patch for your repository!
Url : http://lists.osuosl.org/pipermail/darcs-devel/attachments/20061210/8d8e5b06/attachment.bin


More information about the darcs-devel mailing list