[darcs-devel] Re: darcs patch: Windows hard link support

[Eric Y. Kow]

> >I don't understand Windows -- but that looks completely bogus to me.
> >Does it obey the description in the comment just below?
> 
> Er.  Ok, I completely failed to understand what maybe_relink() was supposed 
> to do, and didn't notice that it should compare the files before attempting 
> to link.  Sorry about that, please ignore the patch, maybe I'll submit a 
> fixed one at some point.

Thanks for watching carefully, Juliusz.  I have rolled this patch back.

Argh... sorry about that, everybody.  My lessons are to read surronding
code more carefully, watch for suspicious stuff like the Windows code
being so much shorter that the Unix stuff, and pay close attention to
inner nuts and bolts.

Simon:
  Please note that you'll probably want to pull in both your patch and
  the rollback before submitting a new one.

Juliusz:
  Will you be able to advise on any new patches on this?
  I definitely plan on moving with much more care on this code.

-- 
Eric Kow                     http://www.loria.fr/~kow
PGP Key ID: 08AC04F9         Merci de corriger mon français.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 186 bytes
Desc: not available
Url : http://lists.osuosl.org/pipermail/darcs-devel/attachments/20061211/4790f1ed/attachment.pgp