[darcs-devel] darcs patch: fix [issue370], darcs ignored args contained in VISUAL...

[Eric Y. Kow]

On Mon, Dec 25, 2006 at 14:20:22 +0100, Eric Y. Kow wrote:
> > Wed Dec 20 12:08:07 CET 2006  Benedikt Schmidt <beschmi at cloaked.de>
> >   * fix [issue370], darcs ignored args contained in VISUAL variable
> >   given VISUAL="emacs -nw", darcs would run "emacs file" instead of
> >   "emacs -nw file"
> 
> This makes me hesitate somewhat.  Can we discuss it a little bit?
> It's probably ok; I just want to see what other people think.
>  
> - This patch will break things for people whose VISUAL has a space in it
>   something like "/c/Program Files/FooEditor"

In an IRC discussion, Benedikt pointed out that we already do the same
thing for wget and ssh.  That's convincing enough for me, so unless
somebody says something to the contrary, I'm going to accept this on
the next cycle.

-- 
Eric Kow                     http://www.loria.fr/~kow
PGP Key ID: 08AC04F9         Merci de corriger mon français.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 186 bytes
Desc: not available
Url : http://lists.osuosl.org/pipermail/darcs-devel/attachments/20061225/abb6b9c3/attachment.pgp