[darcs-devel] darcs patch: handle filenames with whitespace in annotate (issue65)

Benedikt Schmidt beschmi at cloaked.de
Wed May 17 06:07:48 PDT 2006


Annotate doesn't handle filenames with whitespace (see http://bugs.darcs.net/issue65)
consistently.

PopulationData.Info contains nameI and creationNameI as PackedStrings. Since fn2ps
is used to convert a FileName to a PackedString, all whitespace is escaped like
in the patch hunks ('a file' -> 'a\32file').

That's why
darcs annotate 'a file'
can't find 'a file' in the population because there is only a file named 'a\32file'.

This patch uses fn2ps_no_escape for converting the FileNames to PackedStrings in
applyToPop. Another possibility would be using FileNames instead of PackedStrings
for the nameI and creationNameI fields.

Wed May 17 14:48:55 CEST 2006  Benedikt Schmidt <beschmi at cloaked.de>
  * handle filenames with whitespace in annotate (issue65)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: text/x-darcs-patch
Size: 6737 bytes
Desc: A darcs patch for your repository!
Url : http://lists.osuosl.org/pipermail/darcs-devel/attachments/20060517/9098e8a7/attachment.bin


More information about the darcs-devel mailing list