[darcs-devel] darcs patch: Only test for SSH ControlMaster if there... (and 1 more)

[Tommy Pettersson]

On Sun, May 21, 2006 at 07:51:42AM +0200, Eric Kow wrote:
> Sun May 21 06:50:43 CEST 2006  Eric Kow <eric.kow at gmail.com>
>   * Only test for SSH ControlMaster if there are ssh paths in args.

I'm thinking of applying this patch to darcs-stable because
there should most probably be a darcs 1.0.8 soon. I don't know
exactly how annoying issue171 is, since it doesn't happen to me,
but I imagine it is quite so.

However, I don't feel this is the right way to fix the bug, the
usnafePerformeIO appeals more to me, and I'm not sure why the
ssh test is inside the run_command function. But I have only
looked very briefly at the code so I may be totally wrong here.

Unless Juliusz says no (or yes) or I get time to look more at it
(which I won't for yet another week), I'll apply it within some
days.

> +                    let sshServers = nub $ sort [ takeWhile (/= ':') p | p <- ex, is_ssh p ]

Just a note: there is a nubsort in DarcsUtils which I think is
more efficient. (Not that this is a bottle neck in any way
though...)


-- 
Tommy Pettersson <ptp at lysator.liu.se>