[darcs-devel] resend of refactoring patches

[David Roundy]

On Wed, Sep 06, 2006 at 09:17:28PM +0200, Juliusz Chroboczek wrote:
> > Here are all the refactoring patches I've got at the moment.
> 
> Thanks.
> 
> I'm wondering whether finalize/revert shouldn't be renamed to
> commit/rollback, as this is more standard terminology.

I'm not sure.  Either way would be fine with me, and I suspect you
know the standard terminology much better than I do.  My only concern
would be if it could be mistaken for a high level command (e.g. darcs
rollback, which is quite different).

> Other than that, I'm really happy with these changes -- they certainly
> make Darcs a better place to hack.
> 
> > I believe this set passes tests and applies cleanly to current
> > darcs-devel.
> 
> Pretty close:
> 
>   * Fix merge conflicts.
> 
>     M ./Get.lhs -6 +10
>     M ./Optimize.lhs -2 +2
>     M ./Repository.lhs -14 +23
>     M ./Tag.lhs -1 +1
>     M ./list_authors.hs -2 +1
> 
> ...not counting a patch that you amend-recorded and sent twice.

Thanks! I think I wasn't sending from the repository I thought I was
sending from.  :( It's hard to keep track of even one branch, when I
keep travelling.
-- 
David Roundy