[darcs-devel] darcs patch: Fix Windows stderr non-redirection. (and 1 more)

[Tommy Pettersson]

On Sat, Sep 09, 2006 at 09:10:29AM +0200, Eric Kow wrote:
> Correcting my patch and cleaning up my code
> 
> Sat Sep  9 07:52:04 CEST 2006  Eric Kow <eric.kow at gmail.com>
>   * Fix Windows stderr non-redirection.
[...]
> Sat Sep  9 09:07:39 CEST 2006  Eric Kow <eric.kow at gmail.com>
>   * Rename exec_ to exec_fancy.
[...]

I have reviewed this. I think the redirection data type is a
nice idea.

How to redirect stderr is something to think about. As Juliusz
said in an earlier mail, stderr should usually not go to stdout
(by default) when we for example tar and gzip stuff, as it
wrongly has done previously, and still does. I also have some
vague memory about Windows automatically redirecting stderr when
stdout is redirected, unless stderr is explicitly redirected
somewhere else. Can anyone confirm or deny this?

Anyway, I had some difficulty reading the code (most of the code
in Exec.lhs), so I tried to make it more readable, which (for me
at least) means more simple. So I only kept one version of exec
(the fancy one, but with the name exec), and used the
redirection data type all the way. This is merely a suggestion,
for now -- "easy to read" is very subjective. I have changed the
Windows code too, but have not tried to compile it since I don't
have Windows. Since I changed the interface to exec, I've
updated all uses of exec. I did this without deep thought. I
implemented the "keep stderr" on some tar and gzip stuff, but I
mainly just got it to compile and pass the test suite. Only the
changes to Exec.lhs are the interesting stuff. What do you
think?


-- 
Tommy Pettersson <ptp at lysator.liu.se>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ,bundle
Type: text/x-darcs-patch
Size: 35758 bytes
Desc: not available
Url : http://lists.osuosl.org/pipermail/darcs-devel/attachments/20060909/62c8693c/bundle.bin