[darcs-devel] darcs patch: Fix Windows stderr non-redirection. (and 1 more)

[Eric Y. Kow]

> I was thinking of the following (quoted from Juliusz mail):
> | Note that, unless I'm missing something this will also change the
> | behaviour of other commands: ``darcs diff'', for example, will now
> | push any warnings from diff through the darcs printer, rather than
> | printing them directly.  And ``darcs dist'' will print any warnings
> | from tar on stdout rather than stderr, which is clearly wrong.  I
> | haven't checked the other uses of exec and friends, but I bet there
> | are other such issues.
> 
> I think Juliusz is both missing something and is right. (Or I am
> missing something: "redirect stderr to stdout" can mean two
> different things, this can get very confusing.) Anyway, even
> before exec_(fancy), exec would always redirect stderr to the
> same place as stdout, and in some cases this is surely not what
> we want.

Ok, so I think we're on the same page then
- old behaviour : stderr redirected to the same place as stdout was
                  (Juliusz missing something ; nothing has changed)
- old behaviour : not a good idea
                  (Juliusz spot on right)
- new Tommy behaviour : more explicit and consistent

In that case, I'm in favour of your (amended) patch.  Will probably let
it "ripen" till Thursday so that people can comment.

-- 
Eric Kow                     http://www.loria.fr/~kow
PGP Key ID: 08AC04F9         Merci de corriger mon français.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 186 bytes
Desc: not available
Url : http://lists.osuosl.org/pipermail/darcs-devel/attachments/20060910/dff9769b/attachment.pgp