[darcs-devel] darcs patch: Add some rudimentary amend-record + meta... (and 19 more)

[Eric Y. Kow]

On Thu, Aug 02, 2007 at 14:03:24 -0700, David Roundy wrote:
> > +               apply_patches_to_some_files repository path_list $ get_nonrange_match_s opts

> I wonder if it might be better in terms of efficiency to apply patches to
> Slurpies.

Yeah, that was actually what I was aiming for.  I mostly copied the
Diff code.  This function (from Edwin) applies to slurpy and dumps
just the stuff you want to disk.  This makes sense if you want to
call diff or some other program on it, but not if you just want to
show contents.  So we're being silly, only moderately so.

Now watch somebody say that they want to be able to call an external
viewer from show contents.  Actually, another thought I had was that you
might want to supply an output directory with -o (in which case the
above code might make more sense), and links up with what you say below.

> Also, I noticed that the documentation said show contents accepted [FILE or
> DIRECTORY] arguments, but only files actually work (as far as I can see).
> I think it's reasonable to give directory arguments and expect a listing of
> files in that directory... but maybe better to keep this simple.

Well, I think I'll leave that to others :-).  Will submit a patch to fix
the documentation in the meantime.

-- 
Eric Kow                     http://www.loria.fr/~kow
PGP Key ID: 08AC04F9         Merci de corriger mon français.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 186 bytes
Desc: not available
Url : http://lists.osuosl.org/pipermail/darcs-devel/attachments/20070802/2a8d571f/attachment.pgp