[darcs-devel] patch: Pass CFLAGS to assembler

[Dave Love]

"Eric Y. Kow" <eric.kow at gmail.com> writes:

> On Wed, Aug 08, 2007 at 21:00:27 +0200, Lennart Kolmodin wrote:
>> Attached a patch to send the CFLAGS to the assembler, as it otherwise
>> will break arches like sparc which require the -mcpu flag while assembling.
>> 
>> Gentoo Linux has for quite some time applied this to the sources in
>> ebuilds, we thought it was time to give something back :)
>
> Thanks! This will be going in on the next round.

I doubt it should.  I don't understand why it should be necessary on
GNU/Linux (I'm pretty sure it wasn't when I was running Debian on
SPARC), and it isn't necessary on Solaris.  Could you explain?  Worse
than that, CFLAGS are not necessarily appropriate for the assembler:
for instance, my Solaris installation uses Sun `as' with gcc, and that
won't accept `-mcpu'.  Actually, now I think about it, gas won't
either, and it wouldn't make sense -- the compiler back end deals with
instruction sets and scheduling.

> I wonder if http://bugs.darcs.net/issue432 is helped by this at all.
> Any comments, Dave?

I can't think so.  As I said, I'm pretty sure it's something fairly
trivial, and I'll try to find time to debug it sometime if no-one can
give me help with the test and the test framework.