[darcs-devel] darcs patch: Fix issue367 - pull help message. (and 1 more)

[David Roundy]

On Sun, Dec 31, 2006 at 10:31:00PM +0100, Tommy Pettersson wrote:
> On Sun, Dec 31, 2006 at 07:01:08PM +0100, Eric Kow wrote:
> > Sun Dec 31 18:43:22 CET 2006  Eric Kow <eric.kow at gmail.com>
> >   * Fix issue367 - pull help message.
> > 
> > Sun Dec 31 19:00:24 CET 2006  Eric Kow <eric.kow at gmail.com>
> >   * Fix issue376 - inconsistent punctuation in darcs get.
> 
> In the listing of grep !\" *.lhs *.hs dwells a few more lines
> where darcs a bit overly, in my opinion, exclaims the completion
> of a task or finding of no errors.
> 
> Optimize.lhs:106:    putStrLn "Done optimizing!"
> Check.lhs:124:        putInfo $ text "The repository is consistent!"
> 
> Would anyone object if I sent a patch "fixing" these two?

Hmmm.  Just removing them? I sort of like them... but then, I added them in
the first place.  The one in check I consider useful, since otherwise often
the last text seen will be text from a test suite, which won't let you know
that there wasn't some sort of failure (e.g. OOM killer) that caused darcs
to exit without announcing that there was a problem.

The optimizing message does seem unnecesary.
-- 
David Roundy
http://www.darcs.net