[darcs-devel] darcs patch: (add a + mv a b = add b) and (mv a b + remove b = remo...

[Eric Y. Kow]

> > Mon Jan  8 14:09:33 BRST 2007  malebria at riseup.net
> >   * (add a + mv a b = add b) and (mv a b + remove b = remove a)

> I think this is probably fine, but it's a little bit scary.

A nervous David and an ignorant Eric don't make me very keen to accept
this patch just yet, at least not until we've had some more time to
think about it (ahem... namely from the people who understand this stuff
well)

> The reason is that I this change does affect the semantics of a patch.
> It's probably fine, since I think coalesce is only used on pending
> changes, but I'd like to see a bit of a review of where coalesce is
> used, before this patch is accepted.

coalesce seems to be used all over the PatchCommute module.  I can trace
a path up from it to commute_split, eventually up to the commute
function.

Waiting for your green/red light, David.

-- 
Eric Kow                     http://www.loria.fr/~kow
PGP Key ID: 08AC04F9         Merci de corriger mon français.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 186 bytes
Desc: not available
Url : http://lists.osuosl.org/pipermail/darcs-devel/attachments/20070113/3519b95f/attachment.pgp