[darcs-devel] DarcsFlags propagation reduction

[Zachary P. Landau]

On Mon, Jul 02, 2007 at 03:17:06PM -0700, quick at sparq.org wrote:
> This patch may be a little controversial, so I'm prepared to entertain
> discussion and rework this if needed.
> 
> It appears that originally, the command-line options were passed around
> to various functions as the [DarcsFlag] argument, but that eventually
> these options were bound into the Repository class when the latter is
> created (usually via withRepoLock).  This patch removes the explicit
> [DarcsFlag] argument where the flags are available via the Repository
> argument instead.  The intent is to cleanup the interfaces and prevent
> confusion arising from having two different sources for the same
> information.

<snip>

Eric has this under Waiting for discussion, and after all the issues he
addressed this week, the least I can do is try to start the discussion
on this.

I agree that its a good idea not to present two sources for the same
information.  I can't think of a particularly strong argument for why
this is a bad idea.  It touches on a lot of code, but now feels like a
good time for that sort of cleanup.

-- 
Zachary P. Landau <kapheine at divineinvasion.net>
GPG: gpg --recv-key 0xC9F82052 | http://divineinvasion.net/kapheine.asc
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.osuosl.org/pipermail/darcs-devel/attachments/20070722/52925d74/attachment.pgp