[darcs-devel] portability fixes for tests

[Eric Y. Kow]

Ack! Spoke too soon. I am also going to ask you to resubmit this patch
because it makes the following tests fail on MacOS X.
        perms.sh
        posthook.sh
        sametwice.sh

I'm not clear on why you're using /usr/bin/test in some places and test
(which is /bin/test on my Mac) in others.

Sun Feb 25 12:34:02 CET 2007  Dave Love <fx at gnu.org>
  * Fixes for Solaris sh in tests: no $(...), test -e, or ! pipelines.

But thanks for the test suite gardening in any case!

If only somebody would step up and make it work right on Windows.

> You meant '-u, -x flags', right?  Please correct me or resubmit with an
> amended description (sadly, this involves unrecording and re-recording).
> I don't mean to be a pain for such a minor detail, but I'm thinking that
> this might save us some future confusion.

posthook.sh: line 22: /usr/bin/test: No such file or directory

Running sametwice.sh ...                         FAILED!
Output from failed sametwice.sh:

test $DARCS || DARCS=$PWD/../darcs
rm -rf temp1 temp2
mkdir temp1
cd temp1
$DARCS init
echo record author me > _darcs/prefs/defaults
echo ALL all >> _darcs/prefs/defaults
echo ALL verbose >> _darcs/prefs/defaults
echo ALL ignore-times >> _darcs/prefs/defaults
touch foo
$DARCS add foo
Adding 'foo'
diffing dir...
$DARCS record -m add_foo
About to get the unrecorded changes.
diffing dir...
I've gotten unrecorded.
Writing the patch file...
Applying to pristine...
Syncing timestamps...
Finished recording patch 'add_foo'
echo hello >> foo
$DARCS record -m mod_foo
About to get the unrecorded changes.
diffing dir...
I've gotten unrecorded.
Writing the patch file...
Applying to pristine...
Syncing timestamps...
Finished recording patch 'mod_foo'
cd ..
$DARCS get --repo-name temp2 temp1
Copying patch 2 of 2... done.
Finished getting.
cd temp2
cp ../temp1/_darcs/prefs/defaults _darcs/prefs
echo y/d/y | tr / \\012 | $DARCS unpull --interactive
diffing dir...

Sat Mar  3 10:07:56 CET 2007  me
  * mod_foo
Shall I unpull this patch? (1/2)  [ynWvpxqadjk], or ? for help: 

Sat Mar  3 10:07:56 CET 2007  me
  * add_foo
Shall I unpull this patch? (2/2)  [ynWvpxqadjk], or ? for help: 
Finished unpulling.
/usr/bin/test -e foo -a ! -s foo
sametwice.sh: line 23: /usr/bin/test: No such file or directory
Running send.sh ...                              passed.
Running send_apply.sh ...                        passed.
Running several_commands.sh ...                  passed.
Running sigPIPE.sh ...                           passed.
Running ssh.sh ...                               passed.
Running three_way_conflict.sh ...                passed.
Running tricky_unrecord.sh ...                   passed.
Running uniqueoptions.sh ...                     passed.
Running unpull.sh ...                            passed.
Running unrecord.sh ...                          passed.
Running what_sl.sh ...                           passed.
TESTS FAILED!

-- 
Eric Kow                     http://www.loria.fr/~kow
PGP Key ID: 08AC04F9         Merci de corriger mon français.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 186 bytes
Desc: not available
Url : http://lists.osuosl.org/pipermail/darcs-devel/attachments/20070303/6e92614d/attachment-0001.pgp