[darcs-devel] Re: patches accepted 2007-03-17

[Simon Marlow]

Eric Y. Kow wrote:
> On Sat, Mar 17, 2007 at 17:32:37 -0400, Zachary P. Landau wrote:
>>> Rejected (1)
>>> ------------
>>> Sat Mar 10 09:31:37 CET 2007  Eric Kow <eric.kow at gmail.com>
>>>   * Use System.Cmd.system to launch SSH control master.
>> Just out of curiosity, why is this being rejected?  There was only one
>> reply to the email, but one that said the problem wasn't showing up with
>> the patch.
> 
> I used it with one of my other repositories, some other combination of
> patches, and I still saw the problem (or so I thought).  The other
> reason is that I still don't have any idea why it works and I suspect
> that for this kind of thing it'll be useful to do so.  I basically need
> (someone to) look deeper into the Exec stuff and come up with a more
> global explanation and fix, but I don't really have the time for that,
> so I thought it'd be better to just reject this outright rather than
> keep people hanging.
> 
> If you do want to continue using the cm functionality, I am interested
> to see how things work out over time, using this patch and enabling
> --ssh-cm in your defaults.

Another reason to be suspicious of this patch is that it bypasses the existing 
infrastructure for running external processes in darcs.

If using System.Cmd makes a difference, then the right thing to do is to use 
System.Process in exec, because System.Cmd is just a thin wrapper around 
System.Process.

Cheers,
	Simon