[darcs-devel] darcs patch: fix scp whitespace

[Eric Y. Kow]

Hi Misha,

I realise that it was me that requested you sent the patch (for which,
thanks; had completely forgotten about it), but I'm started to have
second thoughts here.

On Thu, May 24, 2007 at 02:58:58 +0200, Misha Aizatulin wrote:
> Thu May 24 01:42:32 CEST 2007  Misha Aizatulin <avatar at hot.ee>
>   * fix scp whitespace
>   
>   see http://bugs.darcs.net/issue454

> +                 tr ' ' = "\\ "

On the one hand, we already escape dollar without really knowing why, so
I guess this isn't that much scarier (although I would rename that
escape_dollar to something else and update the comment).  On the other
hand, I'm a bit disturbed about adding this kind of stuff without having
some kind of justification.  I've tried searching from some kind of
documentation on this, but have only uncovered some random complaints
about whitespace in filenames in OpenSSH's scp as well as a patch to fix
such problems... but no replies, so not sure where to go with this.

Tommy?

-- 
Eric Kow                     http://www.loria.fr/~kow
PGP Key ID: 08AC04F9         Merci de corriger mon français.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 186 bytes
Desc: not available
Url : http://lists.osuosl.org/pipermail/darcs-devel/attachments/20070530/97dbcab6/attachment.pgp