[darcs-devel] darcs patch: FastPackedString.hs: rw linesPS using By... (and 6 more)

[Gwern Branwen]

On 2008.04.11 13:56:50 -0700, David Roundy <droundy at darcs.net> scribbled 1.3K characters:
> Thanks for the patches.  I ended up just not applying the removal and
> re-adding-back of OldFastPackedString.

Well, that works too!

> But I applied the others, and also
> went ahead and removed concatLenPS.

OK. I read your patch, and I agree - iirc, it was only being used in SHA1.lhs, and the only interesting aspect was its strictness (which didn't strike me as very useful in the hashing context).

> Thanks!
>
> David
>
> P.S. Have you by any chance done anything that might fix the known bug in
> the bytestring code? I imagine not, or you'd hopefully have mentioned
> something to that effect, but it's definitely something worth keeping in
> mind.  Of course, it may only manifest itself with certain versions of
> bytestring...  :(

Well, I don't think it's something that appears with different versions of bytestring. So far as I knew, I got bad binaries with bytestring-0.9.0.1, and then got good binaries with bytestring-0.9.0.1 (I try to keep 0.9.0.4 off my system because it leads to an incredible amount of trouble for anything that links in GHC or links in something that links in...GHC).

Now, what did I do to fix the bug? As I said on the bts, I think, my theory is that what I did to fix it was scrapping wfindPS; if it wasn't that, then concatLenPS. I haven't had the heart to go back and restore the original definition and find out though.

--
gwern
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.osuosl.org/pipermail/darcs-devel/attachments/20080411/be8f4f19/attachment.pgp