[darcs-devel] darcs patch: FastPackedString.hs: FastPackedString.hs: redefine lin...

[David Roundy]

On Mon, Apr 14, 2008 at 11:09:15AM -0400, gwern0 at gmail.com wrote:
> Mon Apr 14 11:08:39 EDT 2008  gwern0 at gmail.com
>   * FastPackedString.hs: FastPackedString.hs: redefine linePS/unlinesPS
>   Turns out that my definitions were wrong - they differed and added a
> newline where the old FPS versions didn't. So I've rewritten the wrapper
> versions around ByteString, and checked them against the old ones with
> QuickCheck. With these fixes, a bytestring darcs seems to pass all the
> tests as a fps darcs.

Applied, thanks!

I'd rather have quickcheck tests added to the unit test program, by the
way, than added in a commented manner.  But that's not a big deal, as the
unit test requires quickcheck 2.0, which most developers probably don't
have installed (and it's a pain to have installed, as it means you can't
use quickcheck 1 any more, and quickcheck 2 isn't backwards-compatible).
-- 
David Roundy
Department of Physics
Oregon State University