[darcs-devel] darcs patch: Make Diff.lhs undefined when compiling w... (and 2 more)

[Jason Dagit]

On Thu, Mar 20, 2008 at 8:59 AM, David Roundy <droundy at darcs.net> wrote:

> Hi Jason,
>
> This looks great! I'm a bit surprised that DarcsRepo turned out so nicely
> with so few changes! I read over your one use of unsafeCoerceP pretty
> carefully, and am certain that it's correct.  The rest all looks very
> good.  I'm particularly pleased with your change to commute_to_end, which
> is a real improvement over the previous DarcsRepo code!


Great!

I think we could do even a bit better if we need to, but if DarcsRepo is now
legacy code maybe we should skip it.  The deep_optimize_patchset could be
replaced with, I think, slightly_optimize_patchset (or another variant of
optimize) but run on just the 'skipped' portion since we now maintain the
tags of the 'unmodified' portion of what commute_to_end returns.  I tried
this quickly but I got type errors that I didn't want to deal with so I
opted for the deep_optimize_patchset (which should be redundant on the
'unmodified' portion).

Jason
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.osuosl.org/pipermail/darcs-devel/attachments/20080320/ad278a14/attachment.htm