[darcs-devel] [issue772] bug in get_extra commuting patch

[Lele Gaifax]

On Mon, 31 Mar 2008 18:32:00 -0000
David Roundy <bugs at darcs.net> wrote:

> > So, once you know what the problem is, it's very easy to install a
> > workaround in tailor, just changing the "patch-name-format" option.
> 
> Indeed.  In fact, in tailor you needn't add random garbage, but could
> instead add a little note indicating that the change was generated by
> tailor running on a particular repository.  This wouldn't fix all the
> issue27 problems (e.g. if one svn repository has two different
> changes with identical names and dates), but it would fix this
> particular problem, and would also add human-friendly information.

Well, I think the patch-name-format option offers a good workaround to
that problem as well: by default it rewrites the upstream changelog
prepending something like "[upstream-svn-repo @ 1234]" (where 1234 is
the upstream svn revid) to its text, so effectively those different
changes with identical names and dates [and author, I may add] would
produce /different/ darcs hashes.

I experienced the problem myself exactly because, for the very first
time, I changed that option to avoid that prefix :-)

So the solution for both issues, at least from the tailor point of
view, is just a matter of differentiating in some way the
patch-name-format option.... that is, trusting tailor's default ;-)

I'll add a note about this in the README.

ciao, lele.
-- 
nickname: Lele Gaifax    | Quando vivrò di quello che ho pensato ieri
real: Emanuele Gaifas    | comincerò ad aver paura di chi mi copia.
lele at nautilus.homeip.net |                 -- Fortunato Depero, 1929.

__________________________________
Darcs bug tracker <bugs at darcs.net>
<http://bugs.darcs.net/issue772>
__________________________________