[darcs-devel] [issue1442] does the darcs encoding/decoding of filenames round-trip?

[Eric Kow]

New submission from Eric Kow <kowey at darcs.net>:

% darcs changes 首頁.page -v 
Changes to 首頁.page:

Wed Apr 15 19:35:06 BST 2009  Eric Kow <E.Y.Kow at brighton.ac.uk>
  * Convert \e9\a6\96\e9\a0\81.page from MoinMoin syntax to RST.
    hunk ./\e9\a6\96\e9\160\\81.page 1
    -#language zh-tw
    -#redirect FrontPage

Sun Dec 31 14:13:58 GMT 2006  Eric Kow <q15kxe002 at sneakemail.com>
  * \e9\a6\96\e9\a0\81: redirect to FrontPage
    addfile ./\e9\a6\96\e9\160\\81.page
    hunk ./\e9\a6\96\e9\160\\81.page 1
    +#language zh-tw
    +#redirect FrontPage

And also

% DARCS_DONT_ESCAPE_ANYTHING=1 darcs changes 首頁.page -v 
Changes to 首頁.page:

Wed Apr 15 19:35:06 BST 2009  Eric Kow <E.Y.Kow at brighton.ac.uk>
  * Convert 首頁.page from MoinMoin syntax to RST.
    hunk ./首?\160\?.page 1
    -#language zh-tw
    -#redirect FrontPage

Sun Dec 31 14:13:58 GMT 2006  Eric Kow <q15kxe002 at sneakemail.com>
  * 首頁: redirect to FrontPage
    addfile ./首?\160\?.page
    hunk ./首?\160\?.page 1
    +#language zh-tw
    +#redirect FrontPage

What's going on with those filenames?  What's with the \160 and the double-slash?

Nevermind the actual encoding of the filenames for now.  Once we've got the
filename as a sequence of bytes, do we preserve that sequence?

Hopefully we'll find out that this is just a call for more testing and that
everything is OK.

I claim that the next action required is to study the darcs source code (maybe
Darcs.Patch.FileName) and provide an explanation for \160 and the double slash
that follows (see encode_white).

After that, if all is well, we should probably extend our test suite or make
sure that our test suite covers this stuff.

Marking this as a bug in the absence of full knowledge.

----------
messages: 7709
nosy: dmitry.kurochkin, kowey, simon, thorkilnaur
priority: bug
status: unread
title: does the darcs encoding/decoding of filenames round-trip?

__________________________________
Darcs bug tracker <bugs at darcs.net>
<http://bugs.darcs.net/issue1442>
__________________________________