[darcs-users] new version of trac-darcs plugin

[K.S.Sreeram]

Eric Y. Kow wrote:
> On Wed, Aug 09, 2006 at 04:09:21 +0530, K.S.Sreeram wrote:
>> Eric, can you try the latest trac-darcs from:
>> http://cspace.in/darcs/trac-darcs
>>
>> This latest version uses a darcs diff hack to get file contents rather
>> than using annotate+xml-parsing, so its MUCH faster!
> 
> Indeed, this is much faster! Now for my main project,
> I even dare to click on changesets, like
> http://trac.loria.fr/projects/geni/changeset/821
> 
> My problems with admindt, hylores and curt seem to have gone away, as
> well.
> 
> Many thanks!

You're welcome! Its nice to see that trac-darcs is quite useful!

Speaking of trac-darcs, I thought i'll point out a few bugs/problems
present in the code currently, in case somebody has time to hack on it.

1) Race condition in getting file content (DarcsNode.get_content)
The logic used is:
  - Check if data is cached in db, if yes, load it and return it
  - Fetch data from darcs repository
  - Insert the data into the cache
  - Return the data
As can be seen, a db error occurs when 2 or more requests try to access
the same uncached db data. It fails because the code tries to insert the
same data into the db twice. What is the best approach for solving this
problem? I'm not sure how to use a mutex-like object in this scenario.

2) Database locked error
I've seen this a couple of times myself, though it may not be anything
to do with trac-darcs itself. This needs further investigation.
See this thread on the trac list:
http://lists.edgewall.com/archive/trac/2006-August/009207.html

3) Mysterious sql error inside DarcsNode.get_content
I had a mysterious sqlite db error when trying to insert data into the
darcs cache:
OperationalError: 'SQL logic error or missing database'
After a bit of googling around, I found that setting
'conn.isolation_level = None' solved the problem, though i'm quite sure
this is not the right solution.
See 'DarcsNode.get_content' in tracdarcs/repository.py for more information.

[sreeram;]

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 252 bytes
Desc: OpenPGP digital signature
Url : http://lists.osuosl.org/pipermail/darcs-users/attachments/20060810/47e16c83/attachment.pgp