[darcs-users] [darcs-devel] amend-record fails test behavior: bug or feature?

[Tommy Pettersson]

On Wed, Apr 23, 2008 at 07:31:53PM -0500, Rob Hoelz wrote:
> I was doing an amend-record, and the code I added caused the test suite
> to fail.  After the failure, Darcs behaved as if the patch I was
> amending had never existed
[...]
> Is the old behavior a bug, or a feature?  If the former, I'd happily
> fix it and send my changes here.

This seams to be working as you expect with the hashed and
darcs-2 repo formats. In the old repo format the changes from
the amended patch are left unrecorded if the amend-record fails,
which is not as good, but not really a bug, I think. But if you
want to fix it I think it'd be ok.

> Also, another quick question:  I noticed that the patch resulting from
> amend-record is labeled with the current time, instead of the time of
> the original patch record.  Is this a bug, or is this intentional as
> well?

It is intentional. The author, time and name of a patch
identifies it, so at least one of them must change for darcs to
think it's a different patch.


-- 
Tommy Pettersson <ptp at lysator.liu.se>