[darcs-users] darcs patch: tests/*: refactor remaining IFS calls to lib

[Eric Kow]

Ah, I was just about to write you to report that tests are still passing
after your first patch.

But are you sure this is a good idea, below, to effectively make /every/
test set IFS=''?

The bash manpage says:

IFS    The Internal Field Separator that is  used  for  word  splitting
       after  expansion  and  to  split  lines into words with the read
       builtin  command.   The  default  value  is  ‘‘<space><tab><new‐
       line>’’.

I confess that I still don't fully understand the consquences of this.
One thing I'm worried about is breaking other non-IFS-y tests.  Another
deeper worry is that we start (unknowingly) writing tests that depend
on this behaviour.

What do you think?

tests/*: refactor remaining IFS calls to lib
--------------------------------------------
> hunk ./tests/lib 14
>    exit 0
>  fi
>  }
> +
> +# A hack for Cygwin; makes future calls to hspwd work
> +IFS=''
> hunk ./tests/mv-formerly-pl.sh 120
 
-- 
Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow>
PGP Key ID: 08AC04F9
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
Url : http://lists.osuosl.org/pipermail/darcs-users/attachments/20081201/15628f14/attachment.pgp