[darcs-users] darcs patch - [issue871] bug in darcs! Impossible case src/Lcs.lhs:173 (2.0.0 +253)
Pekka Pessi
ppessi at gmail.com
Thu May 22 06:37:52 UTC 2008
2008/5/22 Eric Kow <bugs at darcs.net>:
> Do you know what sequence of darcs command(s) triggered this? From what you're
> saying, we should be able to solve this with a simple rollback, right?
> Hopefully we can generate a test case for Pekka.
>
> I'll +droundy when we've settled this basic triage-y stuff (unless he's already
> paying attention)
Oops. While I could not figure out how it could happen, culprit is
kind a obvious. dontShiftLast stuff in diffArr does not check that
bits both in c_a and c_b are True when changing them to False.
The following patch moves the end-of-file check to shiftBoundaries.
I can not compile unit tests for shiftBoundaries, so they might fail.
Does they need ghc 6.6? Some extra package?
--
Pekka.Pessi mail at nokia.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: making-sure-hunk-is-not-shifted-beyond-end-of-file-in-shiftboundaries.dpatch
Type: application/octet-stream
Size: 36172 bytes
Desc: not available
Url : http://lists.osuosl.org/pipermail/darcs-users/attachments/20080522/9ec77d13/attachment-0001.obj
More information about the darcs-users
mailing list