[darcs-users] [issue871] patch for darcs - fix for LCS

[David Roundy]

On Thu, May 22, 2008 at 06:11:20PM +0300, Pekka Pessi wrote:
> Hm... gmail seems to be unusually slow today. Resending. 2nd time.

Applied.  Thanks!

> 2008/5/22 Eric Kow <bugs at darcs.net>:
> > Do you know what sequence of darcs command(s) triggered this?  From what you're
> > saying, we should be able to solve this with a simple rollback, right?
> > Hopefully we can generate a test case for Pekka.
> >
> > I'll +droundy when we've settled this basic triage-y stuff (unless he's already
> > paying attention)
> 
> Oops. While I could not figure out how it could happen, culprit is
> kind a obvious. dontShiftLast stuff in diffArr does not check that
> bits both in c_a and c_b are True when changing them to False.
> 
> The following patch moves the end-of-file check to shiftBoundaries.
> 
> I can not compile unit tests for shiftBoundaries, so they might fail.
> Does unit tests need ghc 6.6? Some extra package?

The unit tests require quickcheck 2.0.

David