[darcs-users] darcs patch: +tests/lib.sh: library for test scripts (and 3 more)

[Gwern Branwen]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

On Sat, Nov 15, 2008 at 4:33 PM, Christian Kellermann  wrote:
> Hi!
>
> Wow, this was long and dull work! Thanks!
>
> * gwern0 at gmail.com  [081115 22:16]:
>> Sat Nov 15 15:16:08 EST 2008  gwern0 at gmail.com
>>   * +tests/lib.sh: library for test scripts
>>   This adds a file to the tests directory for storing function
definitions. This will cut down on silliness like 'not' being defined
in 63 different scripts - the exact same way.
>
> ok
>
>>
>> Sat Nov 15 15:18:47 EST 2008  gwern0 at gmail.com
>>   * tests/*.sh: factor out definitions of portable_pwd to lib.sh
>
> Moves the cygwin path helper code into a shell function in lib.sh
>> Sat Nov 15 15:57:35 EST 2008  gwern0 at gmail.com
>>   * tests/*.sh: factour out ~61 of the 'not' definitions to lib.sh
>
> If you didn't miss a file by accident these are correct.

I had to leave in a number of redefinitions. For starters, I didn't
even touch anything in bugs/; and it seems one is not allowed to do '.
..lib.sh', so I had to leave tests/network/bugs.sh alone, and finally,
tests/mark-conflicts.sh simply doesn't work if I replace the 'not'
with '. lib.sh'.

Why doesn't mark-conflicts work? I haven't foggiest. It looks just
like all the other scripts which work with that change. If somebody
knows the answer to that mystery...

>> Sat Nov 15 16:09:59 EST 2008  gwern0 at gmail.com
>>   * tests/*.sh: factor out windows abortion
>
> adds a function to print an explanation that this particular test
> does not work on windows

Well, it also kills the calling script immediately, if I understand
it. Hence the 'abort' part.

> Maybe someday we will have a nice testsuite :)
>
> Kind regards,
>
> Christian

- --
gwern
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEAREKAAYFAkkfTIAACgkQvpDo5Pfl1oKx2wCfYQWd2Czrnm1csyoYFb4zkDjs
bxEAnRw7rTLixNVR/pO7U/8e5KAlb66J
=A8IZ
-----END PGP SIGNATURE-----