[darcs-users] darcs patch: tests/lib: scrap portable_pwd definition... (and 2 more)

[Gwern Branwen]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

On Tue, Nov 18, 2008 at 6:56 AM, Eric Kow  wrote:
> Hi,
>
> I'm applying these, provided tests pass in my staging repo...
>
> tests/lib: scrap portable_pwd definition for alias to hspwd
> -----------------------------------------------------------
> looks ok to me
>
> tests/*: per kowey, replace all portable_pwd with hspwd
> -------------------------------------------------------
>> replace ./tests/filepath.sh [A-Za-z_0-9] portable_pwd hspwd
>> replace ./tests/get.sh [A-Za-z_0-9] portable_pwd hspwd
>> replace ./tests/issue1057.sh [A-Za-z_0-9] portable_pwd hspwd
>> replace ./tests/issue1078_symlink.sh [A-Za-z_0-9] portable_pwd hspwd
>> replace ./tests/mv-formerly-pl.sh [A-Za-z_0-9] portable_pwd hspwd
>> replace ./tests/pull.sh [A-Za-z_0-9] portable_pwd hspwd
>> replace ./tests/push-formerly-pl.sh [A-Za-z_0-9] portable_pwd hspwd
>> replace ./tests/put.sh [A-Za-z_0-9] portable_pwd hspwd
>> replace ./tests/record.sh [A-Za-z_0-9] portable_pwd hspwd
>> replace ./tests/toolbox.sh [A-Za-z_0-9] portable_pwd hspwd
>> replace ./tests/whatsnew.sh [A-Za-z_0-9] portable_pwd hspwd
>
> It may be worth hunting through these scripts in a future patch to mop
> up any residual portable_pwd-related or Cygwin-related comments and also
> the IFS='' hack
>
> tests/README: add a section warning about use of 'yes' and 'find'
> -----------------------------------------------------------------
>> +- Also try to be careful using certain utilities; 'yes' is prohibited since
>> +  it can cause infinite loops on Mac OS X; 'find' can be very useful, but
>> +  options and behavior can differ from GNU find to the BSD finds
to Solaris's
>> +  find and so on. In general, stick to POSIX flags and functionality.
>> +
>
> Yay for documentation!

Attached is a patch removing the IFS calls. The tests pass on my Linux machine.

- --
gwern
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEAREKAAYFAkknKwYACgkQvpDo5Pfl1oIa2gCgn2RsLXLTHwnBKHiT/svsXjoE
C98AoIlJ+NvVnh5DBhGY22Jabx+jfzq0
=fnsD
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ifs.dpatch
Type: application/octet-stream
Size: 179373 bytes
Desc: not available
Url : http://lists.osuosl.org/pipermail/darcs-users/attachments/20081121/d91e5097/attachment-0001.obj