[darcs-users] darcs patch: tests/lib: scrap portable_pwd definition... (and 2 more)

[Gwern Branwen]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

On Sun, Nov 30, 2008 at 5:24 PM, Eric Kow  wrote:
> On Sun, Nov 30, 2008 at 16:11:44 -0500, Gwern Branwen wrote:
>> Did the buildbot report which tests failed? It'd be valuable to know
>> whether it was just one or two, or all of them. (If the former, then
>> we can go and delete all the excess ones; if the latter, then we could
>> stick IFS='' in lib and remove them anyway - we wouldn't even need a
>> conditional, as they obviously do nothing on Linux.)
>
> Here it is, I think:
>
> get.sh
> issue1078_symlink.sh
> issue595_get_permissions.sh
> push-formerly-pl.sh
> put.sh
> record.sh
> whatsnew.sh
>
> http://buildbot.darcs.net/builders/reinier%20sloompie%20Linux-2.6.21.5%20Slackware-12.0%20i686/builds/232/steps/test/logs/stdio
>
> I found this by typing in build numbers by hand and checking darcs
> changes.  There probably was a more efficient way to go about it.

OK then. By my count, that's not every IFS user:

gwern at craft:30743bin/darcs/darcs.net/tests>grep -l "IFS=''" *
filepath.sh
get.sh
issue1057.sh
issue1078_symlink.sh
issue595_get_permissions.sh
push-formerly-pl.sh
put.sh
query_manifest.sh
record.sh
toolbox.sh
whatsnew.sh

The odd men out are:

filepath.sh
issue1057.sh
query_manifest.sh
toolbox.sh

So I'll send a patch removing IFS from those 4, and then we can make
the other 7 call lib?

- --
gwern
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEAREKAAYFAkkzJYkACgkQvpDo5Pfl1oKUJwCaAiHTk34mxJFpXJlZvlhU57b6
FA8Anj1btqVcwmLS7r7iMj8EECyULHh5
=htch
-----END PGP SIGNATURE-----