[darcs-users] darcs patch: resolve issue1015: workaround internal API change on W...

[David Roundy]

On Tue, Sep 02, 2008 at 10:20:42AM +0100, Eric Y. Kow wrote:
> On Tue, Sep 02, 2008 at 01:31:19 +0200, Petr Rockai wrote:
> > Hi, let me just to do some random patch review (would I get some karma for
> > that, lispy?), this seems like an easy one.
> 
> Heh :-)
> 
> Thanks, in either case.

Indeed, thanks to both of you!  :) And easy patch reviews do have the
benefit (even if they don't actually help catch bugs) of providing
practice reading patches, and giving a new perspective as to what
constitutes a nicely formulated patch.

> > > [resolve issue1015: workaround internal API change on Windows in GHC 6.8.3
> > > Ganesh Sittampalam <ganesh at earth.li>**20080901223420] hunk ./src/win32/System/Posix/Files.hsc 49
> > > -    return (FileStatus tp mode mtime size)
> > > +    return (FileStatus tp mode mtime (fromIntegral size))
> 
> > Looks like a decent workaround with no collateral damage. Unfortunately, I
> > don't have Windows to actually try it out.
> 
> Well, Petr and Simon think it's fine and I agree it's harmless looking,
> so I'll fast-track this as soon as the infrastructure is in place. 

I agree also.  The only possible danger of fromIntegral is that it can
obscure bugs by defeating the type checker, but that doesn't seem to
be the case here.  It's a great way to handle unstable APIs.

Applied.  (but yes, everythings waiting on this stupid power
outage... Oregon is just not the best place to get your electricity.
I think it's usually the squirrels, although I don't see how they
could take out a transformer that's actually *in* the building.)

David