[darcs-users] darcs patch: Change type of subdir parameter in Cache... (and 2 more)

Jason Dagit dagit at codersbase.com
Tue Sep 2 20:14:10 UTC 2008


On Tue, Sep 2, 2008 at 12:54 PM,  <me at mornfall.net> wrote:

> Now, since I have already converted two of my controvesial ideas into patches,
> I'll ask about the last one before taking action. I suggest adding following
> aliases to improve code readability (names are subject to debate, I suppose):
>
> mkdir = createDirectoryIfMissing False
> mkdirRecursive = createDirectoryIfMissing True

I would be very supportive of change here that made the bool parameter
more obvious.  But, a less invasive change might be to replace the
Bool with
data Recursive = Recursive | NotRecursive

> mkdirNew = createDirectory

We wouldn't need this new alias with my proposed change.

Thanks Mornfall!

Jason


More information about the darcs-users mailing list