[darcs-users] darcs patch: Change type of subdir parameter in Cache... (and 2 more)

[Petr Rockai]

"Jason Dagit" <dagit at codersbase.com> writes:
>> Now, since I have already converted two of my controvesial ideas into patches,
>> I'll ask about the last one before taking action. I suggest adding following
>> aliases to improve code readability (names are subject to debate, I suppose):
>>
>> mkdir = createDirectoryIfMissing False
>> mkdirRecursive = createDirectoryIfMissing True
>
> I would be very supportive of change here that made the bool parameter
> more obvious.  But, a less invasive change might be to replace the
> Bool with
I'm not really convinced that it's that non-invasive. createDirectoryIfMissing
is a library routine, so we would need to come up with a new name to pass the
Recursive | NotRecursive parameter to anyway. (Yes, we have a Workaround for
createDirectoryIfMissing, but I think changing signatures of library functions
will only add confusion...)

Yours,
   Petr.

-- 
Peter Rockai | me()mornfall!net | prockai()redhat!com
 http://blog.mornfall.net | http://web.mornfall.net

"In My Egotistical Opinion, most people's C programs should be
 indented six feet downward and covered with dirt."
     -- Blair P. Houghton on the subject of C program indentation