[darcs-users] darcs patch: Change type of subdir parameter in Cache... (and 2 more)

Petr Rockai me at mornfall.net
Tue Sep 2 20:46:33 UTC 2008


Hi,

"Jason Dagit" <dagit at codersbase.com> writes:
> But, I wonder about this hunk:
> hunk ./src/Darcs/Repository/HashedIO.lhs 70
>  -}
>
>  data HashDir r p = HashDir { permissions :: !r, cache :: !Cache,
> -                             options :: ![DarcsFlag], rootHash :: !String,
> -                             hashDir :: !String }
> +                             options :: ![DarcsFlag], rootHash :: !String }
>  type HashedIO r p = StateT (HashDir r p) IO
>
> Why did you remove the hashDir from the record?  Why did you change
> hashDir :: HashedDir?
ah this one got obsoleted -- noone's using hashDir anymore -- I have actually
introduced it myself, when I have still been using "newpristine" for the
"hashed" repair. The HashDir type is not used for anything but pristine. It
might want to be renamed, as it's been pointed out elsewhere.

Thanks for the feedback!
Yours,
   Petr.

-- 
Peter Rockai | me()mornfall!net | prockai()redhat!com
 http://blog.mornfall.net | http://web.mornfall.net

"In My Egotistical Opinion, most people's C programs should be
 indented six feet downward and covered with dirt."
     -- Blair P. Houghton on the subject of C program indentation


More information about the darcs-users mailing list