[darcs-users] darcs patch: Add a test for binary patch files.
Trent W. Buck
trentbuck at gmail.com
Wed Sep 10 01:34:02 UTC 2008
Eric Kow <kowey at darcs.net> writes:
> Tis test passes and seems to make sense, so I have fast-tracked it
> into stable.
>
> But do please have a look at tests/README.test_maintainers.txt for tips
> on improving tests.
>
>> +#!/bin/sh
>
> For some reason we have decided to switch to explicit uses of bash.
Presumably because inadvertent bashisms (like "function" below!) in a
script that claims to run on /bin/sh really annoying people for whom sh
is not bash. Since the set of people who don't want to install bash is
a strict subset of the people for whom sh is not bash[0], explicit use
of bash in shebangs means that fewer people are annoyed. (I'm assuming
that it's impossible to catch all bashisms submitted by developers.)
>> +binary=mybinary.jpg
>> +function checkbinary(){
>> + cmp $binary ../temp1/$binary
>> +}
[0] Proof: I'm happy to install bash, but my sh is dash.
More information about the darcs-users
mailing list