[darcs-users] darcs patch: Resolve issue1373: make --token-chars [^ \t\n] work as...

Trent W. Buck trentbuck at gmail.com
Mon Apr 6 09:54:02 UTC 2009


Tommy Pettersson <ptp at lysator.liu.se> writes:

> So this fix should be rolled back ASAP!
>
> When I think about it, my old space check is probably
> incomplete, since a token char specifier of [^x] would permit
> replace tokens with spaces in them, which would also create a
> broken patch.

OK, so moving forward from here, we need to

* prevent any token-chars that contains whitespace (the rollback).
* prevent any token-chars that starts with a ^.
* update the documentation to reflect that ^ isn't allowed.

Tommy, do you agree?



More information about the darcs-users mailing list