[darcs-users] index format
Eric Kow
kowey at darcs.net
Mon Jun 8 15:17:13 UTC 2009
On Mon, Jun 08, 2009 at 08:08:25 -0700, Jason Dagit wrote:
> > The only place where dirlen is Nothing is when peekItem is called from
> > createItem. In this case, iName is never used, so the code is safe. Both
> > createItem and peekItem are supposed to be private in the Index module.
> > (I'll
> > add a remark that they are unsafe and I'll add explicit export list to the
> > module).
>
> My recommendation is to make that field hold a Maybe instead of the raw
> value.
Alternatively, we could have a version used by createItem without the
dirlen field and a general version which takes a mandatory field. I
don't know if this would lead to something ugly though.
--
Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow>
PGP Key ID: 08AC04F9
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
URL: <http://lists.osuosl.org/pipermail/darcs-users/attachments/20090608/a7dab631/attachment.pgp>
More information about the darcs-users
mailing list