[darcs-users] darcs patch: resolve issue1412: also adjust maxline in PatchCheck u...

Reinier Lamers tux_rocker at reinier.de
Tue Jun 9 23:01:25 UTC 2009


This fixes all of the unit test failures in the command that first generated five:

  dist/build/unit/unit -r '1387922338 2147483372,86'

I optimistically assume that this fixes all of issue 1412, but you are of
course welcome to re-open it if you still see unit test failures.

The problem was that the patch checking code in Darcs/Patch/Check.hs did not
accurately track the highest known line number in a file, so that file_empty
could falsely return True, so that binary patches and remove-file patches
were allowed by the checking code in places where they should not have been
allowed.


Wed Jun 10 00:12:37 CEST 2009  Reinier Lamers <tux_rocker at reinier.de>
  * resolve issue1412: also adjust maxline in PatchCheck upon insert_line

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: text/x-darcs-patch
Size: 83726 bytes
Desc: A darcs patch for your repository!
URL: <http://lists.osuosl.org/pipermail/darcs-users/attachments/20090610/6a716cd3/attachment-0001.bin>


More information about the darcs-users mailing list