[darcs-users] darcs patch: Resolve issue1351: fix repository path handling on Windows (and 1 more).

[Eric Kow]

On Sun, May 10, 2009 at 09:24:41 +0200, Salvatore Insalaco wrote:
> On Sun, May 10, 2009 at 3:47 AM, Eric Kow <kowey at darcs.net> wrote:
> > On Sat, May 09, 2009 at 21:19:48 +0200, Salvatore Insalaco wrote:
> > Hopefully we can one day spin off our RepoPath and our path-fixing
> > code to be a standalone module.
> 
> I think that we can spin-off much more to System.Directory and
> System.FilePath (yes, I read the 2008 thread about that), but we

Could you remind me which thread that is?

> should start to use Windows paths for Windows and Posix paths for
> Posix.
> It's ok to use Posix for relative path inside the repository, as they
> need to be cross platform.
> The only environment where this possibly make some mess is Cygwin, but
> we could always add a compilation flag that forces Posix paths in
> there.

I'm not opposed to any of this.  It'll probably require some careful
auditing, though just to make sure it really is a safe to do this.

> > Could I be annoying and ask you to amend --edit that patch, wrapping
> > that description at 72 characters?
> 
> Sure! Sorry for not being careful the first time :).

Applied, thanks!

-- 
Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow>
PGP Key ID: 08AC04F9
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 194 bytes
Desc: not available
URL: <http://lists.osuosl.org/pipermail/darcs-users/attachments/20090512/587eb4c8/attachment.pgp>