[darcs-users] can we get rid of perl requirement in our test suite?

Eric Kow kowey at darcs.net
Mon May 18 17:14:15 UTC 2009


Hi Dan,

On Fri, May 15, 2009 at 03:53:21 +0300, Dan Pascu wrote:
> If you do not care about the char being 'a' and can use a file filled with 
> '0' instead, just remove the tr command to make it even faster:
> 
> printf "%01048000d" 0

This sounds like a simple portable solution.  I don't think we
particularly need the character to be 'a' either.  Would you mind
submitting a patch?  It's tests/pull_binary.sh

Help with the other two perlisms would also be nice, unless, Salvatore,
you've already got a plan up your sleeves for that :-)

tests/optimize_relink.sh:  echo 'use File::Basename; $res=0; while
($fn=<'$1'/*>) { $fn2="'$2'/" . basename($fn); @fd1=lstat($fn);
@fd2=lstat($fn2); $res += ($fd1[1] != $fd2[1]);}; exit($res);' | perl

tests/pull_compl.sh:    perl -i~ -pe "$1" foo

It sounds like the latter can be replaced with some sed usage, which we
already use in the test suite quite a bit.

Thanks!

-- 
Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow>
PGP Key ID: 08AC04F9
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
URL: <http://lists.osuosl.org/pipermail/darcs-users/attachments/20090518/b4e11380/attachment.pgp>


More information about the darcs-users mailing list