<div dir="ltr"><br><br><div class="gmail_quote">On Thu, Oct 2, 2008 at 6:41 PM, Max Battcher <span dir="ltr"><<a href="mailto:me@worldmaker.net">me@worldmaker.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div class="Ih2E3d">Trent W. Buck wrote:<br>
> Eric Kow <<a href="mailto:kowey@darcs.net">kowey@darcs.net</a>> writes:<br>
><br>
>> On Thu, Oct 02, 2008 at 15:19:46 -0400, Max Battcher wrote:<br>
>>> meaningful when it shows up in .dpatch-es. For instance, "Patch-salt:"<br>
>>> would provide more information about what that field is and why the UI<br>
>>> hides it but it is contained in the patches.<br>
><br>
> +1, for the reasons Eric gives:<br>
><br>
>> Interesting thought. The code is designed to allow us to rename or<br>
>> add more ignorable fields in the future. Indeed "Patch salt" sounds<br>
>> more informative. Send a patch?<br>
<br>
</div>Sent a patch adding "Patch-salt: " to the appropriate list, which was<br>
interesting to search for, not having too great of a sense of darcs'<br>
repository organization.<br>
<div class="Ih2E3d"><br>
> Also, RFC 822 specifies extension fields have names starting with "X-".<br>
> Perhaps a similar convention could be used here? That is, as separate<br>
> features:<br>
><br>
> - by default, darcs suppresses X- fields in user output.<br>
> - darcs >>2.1 uses X-Patch-Salt internally to avoid <a problem>.<br>
<br>
</div>Well, Patch-salt isn't really an extension field to darcs as the<br>
proposal is to make it standard, by default, always on in darcs. On the<br>
other hand, extending the current ignore support to support a Regex such<br>
as "^X\-([\w\-]+): " might provide a useful extension area for third<br>
party tools to use (for example "X-Tailor-Something: ").</blockquote><div><br>I just want to go on the record as saying:<br>1) I support adding user definable attributes to patches.<br>2) I dislike adding attributes to patches by take over the long descriptions of patches.<br>
<br><br>Jason<br><br><br></div></div><br></div>