<div dir="ltr"><br><br><div class="gmail_quote">On Tue, Oct 14, 2008 at 2:48 PM, David Roundy <span dir="ltr"><<a href="mailto:droundy@darcs.net">droundy@darcs.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div class="Ih2E3d">On Tue, Oct 14, 2008 at 01:42:39PM -0700, Jason Dagit wrote:<br>
> On Tue, Oct 14, 2008 at 10:32 AM, Nathan Gray <<a href="mailto:kolibrie@graystudios.org">kolibrie@graystudios.org</a>>wrote:<br>
><br>
> > On Tue, Oct 14, 2008 at 01:09:55PM -0400, David Roundy wrote:<br>
> > > Here's an amended refactor of my previous pre/post-hook change. I'm<br>
> > > still hoping for comments from someone other than Jason. Not that I<br>
> > > don't appreciate Jason's comments, but given that we disagree it seems<br>
> > > like a good idea to get more feedback from *someone*.<br>
> ><br>
> [snip]<br>
><br>
> > I would recommend making run-posthook the default, or eliminating it.<br>
> ><br>
> > I would recommend keeping prompt-posthook as an option.<br>
><br>
> This is similar what I was recommending, but in many fewer words. I'm also<br>
> advocating we keep the option for disabling the posthook.<br>
<br>
</div>Let me reiterate that I never suggested removing that option, nor have<br>
I posted code that would do so.</blockquote><div><br>If we're keeping prompt and disable then it seems fine. I glanced at the patches it I couldn't tell what the extent was.<br><br>Jason</div></div><br></div>