<br><br><div class="gmail_quote">On Sat, Sep 26, 2009 at 1:37 PM, Reinier Lamers <span dir="ltr"><<a href="mailto:tux_rocker@reinier.de">tux_rocker@reinier.de</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Hi all,<br>
<br>
Here's a review of the first two patches. I want to know if you really want to undo some changes that your patches have conflicted with. If so, I will push it, otherwise, please amend.<br></blockquote><div><br>I have some commentary to add. I haven't read the patch carefully yet, but I see this:<br>
+pullItNow :: (RepoPatch p) =><br>+ Repository p -> [DarcsFlag] -> FL (PatchInfoAnd p)<br>+ -> RL (PatchInfoAnd p) -> IO ()<br><br>pullItNow needs a type-witness type signature.<br>
<br>And it's not the only one, I also see:<br>+makeBundleFromSelection :: <br>+ RepoPatch p => [DarcsFlag] -> (RL (PatchInfoAnd p)) -> [PatchInfo]<br>+ -> FL (PatchInfoAnd p ):> FL (PatchInfoAnd p)<br>
+ -> IO (Doc, Int)<br><br>And this one:<br>+recordItNow :: RepoPatch p => [DarcsFlag] -> String -> String -> Repository p -> <br>+ (FL Prim :> FL Prim) -> IO ()<br><br>If you push the bundle how it is now, then I expect it to break the buildbot.<br>
<br>Jason<br></div></div>