<br><br><div class="gmail_quote">On Wed, Oct 7, 2009 at 10:47 PM, Trent W. Buck <span dir="ltr"><<a href="mailto:twb@cybersource.com.au">twb@cybersource.com.au</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Warning: I am not pulling punches in this review. Please understand<br>
this is a critique of the patch, not a personal attack on anybody.<br>
<br>
</blockquote><div><br>Same here. I have a few, extremely minor comments below.<br> <br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
> - "provide an explicit path to this program; otherwise the standard",<br>
> - "locations /usr/sbin/sendmail and /usr/lib/sendmail will be tried."])<br>
<div class="im">> + "provide an explicit path to this program. If `--sendmail-command' is",<br>
> + "not present, $SENDMAIL is used; if both are not present, the standard",<br>
> + "locations /usr/sbin/sendmail and /usr/lib/sendmail are used. (Other",<br>
<br>
</div>What was the rationale for the rewording above?<br></blockquote><div><br>As long as it's technically correct, I think the rewording is nice because it gives a clear picture of the order of defaulting.<br> </div>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><br>
<div class="im"><br>
> + "If your machine has no working MTA (mail server), it may loose your",<br>
</div><div class="im">> + "e-mails without telling you. In that case, take a look at msmtp and",<br>
> + "the offline wrapper msmtp-runqueue.sh.",<br>
> + "Example: `--sendmail-command=\"/usr/local/bin/msmtp-enqueue.sh -a me %<\"'",<br>
> + "(Without %<, the e-mail is not piped into your MTA's stdin.)"])<br></div></blockquote><div><br>I think Knuth[1] makes a pretty convincing argument for "email" instead of "e-mail": <br>
<blockquote style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;" class="gmail_quote"><h3>
A note on email versus e-mail
</h3><p>
Newly coined nonce words of English are often spelled with a hyphen, but the
hyphen disappears when the words become widely used. For example, people
used to write ``non-zero'' and ``soft-ware'' instead of ``nonzero''
and ``software''; the same trend has occurred for hundreds of
other words. Thus it's high time for everybody to stop using the archaic
spelling ``e-mail''. Think of how many keystrokes you will save in
your lifetime if you stop now! The form ``email'' has been well
established in England for several years, so I am amazed to see
Americans being overly conservative in this regard. (Of course,
``email'' has been a familiar word in France, Germany, and the Netherlands
much longer than in England --- but for an entirely different reason.)
</p></blockquote><div>[1] <a href="http://www-cs-faculty.stanford.edu/~knuth/email.html">http://www-cs-faculty.stanford.edu/~knuth/email.html</a><br><br><br>Jason<br></div></div></div>