<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p><br>
</p>
<div class="moz-cite-prefix">On ١٦/٤/٢٠٢٢ ١٣:٣١, Julia Lawall
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:alpine.DEB.2.22.394.2204161331080.3501@hadrien">
<pre class="moz-quote-pre" wrap="">
On Sat, 16 Apr 2022, Alaa Mohamed wrote:
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">Convert kmap() to kmap_local_page()
With kmap_local_page(), the mapping is per thread, CPU local and not
globally visible.
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
It's not clearer. </pre>
</blockquote>
I mean this " fix kunmap_local path value to take address of the
mapped page" be more clearer<br>
<blockquote type="cite"
cite="mid:alpine.DEB.2.22.394.2204161331080.3501@hadrien">
<pre class="moz-quote-pre" wrap="">This is a general statement about the function. You
need to explain why it is appropriate to use it here. Unless it is the
case that all calls to kmap should be converted to call kmap_local_page.</pre>
</blockquote>
<p>It's required to convert all calls kmap to kmap_local_page. So, I
don't what should the commit message be?</p>
<p>Is this will be good :</p>
<p>"<span style="color: rgb(51, 51, 51); font-family: -apple-system,
BlinkMacSystemFont, "Segoe UI", Roboto,
"Helvetica Neue", Arial, "Noto Sans",
"Liberation Sans", sans-serif, "Apple Color
Emoji", "Segoe UI Emoji", "Segoe UI
Symbol", "Noto Color Emoji"; font-size: 16px;
font-style: normal; font-variant-ligatures: normal;
font-variant-caps: normal; font-weight: 400; letter-spacing:
normal; orphans: 2; text-align: left; text-indent: 0px;
text-transform: none; white-space: normal; widows: 2;
word-spacing: 0px; -webkit-text-stroke-width: 0px;
background-color: rgb(255, 255, 255); text-decoration-thickness:
initial; text-decoration-style: initial; text-decoration-color:
initial; display: inline !important; float: none;">kmap_local_page()
was recently developed as a replacement for kmap(). The</span><br
style="box-sizing: border-box; color: rgb(51, 51, 51);
font-family: -apple-system, BlinkMacSystemFont, "Segoe
UI", Roboto, "Helvetica Neue", Arial, "Noto
Sans", "Liberation Sans", sans-serif, "Apple
Color Emoji", "Segoe UI Emoji", "Segoe UI
Symbol", "Noto Color Emoji"; font-size: 16px;
font-style: normal; font-variant-ligatures: normal;
font-variant-caps: normal; font-weight: 400; letter-spacing:
normal; orphans: 2; text-align: left; text-indent: 0px;
text-transform: none; white-space: normal; widows: 2;
word-spacing: 0px; -webkit-text-stroke-width: 0px;
background-color: rgb(255, 255, 255); text-decoration-thickness:
initial; text-decoration-style: initial; text-decoration-color:
initial;">
<span style="color: rgb(51, 51, 51); font-family: -apple-system,
BlinkMacSystemFont, "Segoe UI", Roboto,
"Helvetica Neue", Arial, "Noto Sans",
"Liberation Sans", sans-serif, "Apple Color
Emoji", "Segoe UI Emoji", "Segoe UI
Symbol", "Noto Color Emoji"; font-size: 16px;
font-style: normal; font-variant-ligatures: normal;
font-variant-caps: normal; font-weight: 400; letter-spacing:
normal; orphans: 2; text-align: left; text-indent: 0px;
text-transform: none; white-space: normal; widows: 2;
word-spacing: 0px; -webkit-text-stroke-width: 0px;
background-color: rgb(255, 255, 255); text-decoration-thickness:
initial; text-decoration-style: initial; text-decoration-color:
initial; display: inline !important; float: none;">kmap_local_page()
creates a mapping which is restricted to local use by a</span><br
style="box-sizing: border-box; color: rgb(51, 51, 51);
font-family: -apple-system, BlinkMacSystemFont, "Segoe
UI", Roboto, "Helvetica Neue", Arial, "Noto
Sans", "Liberation Sans", sans-serif, "Apple
Color Emoji", "Segoe UI Emoji", "Segoe UI
Symbol", "Noto Color Emoji"; font-size: 16px;
font-style: normal; font-variant-ligatures: normal;
font-variant-caps: normal; font-weight: 400; letter-spacing:
normal; orphans: 2; text-align: left; text-indent: 0px;
text-transform: none; white-space: normal; widows: 2;
word-spacing: 0px; -webkit-text-stroke-width: 0px;
background-color: rgb(255, 255, 255); text-decoration-thickness:
initial; text-decoration-style: initial; text-decoration-color:
initial;">
<span style="color: rgb(51, 51, 51); font-family: -apple-system,
BlinkMacSystemFont, "Segoe UI", Roboto,
"Helvetica Neue", Arial, "Noto Sans",
"Liberation Sans", sans-serif, "Apple Color
Emoji", "Segoe UI Emoji", "Segoe UI
Symbol", "Noto Color Emoji"; font-size: 16px;
font-style: normal; font-variant-ligatures: normal;
font-variant-caps: normal; font-weight: 400; letter-spacing:
normal; orphans: 2; text-align: left; text-indent: 0px;
text-transform: none; white-space: normal; widows: 2;
word-spacing: 0px; -webkit-text-stroke-width: 0px;
background-color: rgb(255, 255, 255); text-decoration-thickness:
initial; text-decoration-style: initial; text-decoration-color:
initial; display: inline !important; float: none;">single thread
of execution. "<br>
</span></p>
<blockquote type="cite"
cite="mid:alpine.DEB.2.22.394.2204161331080.3501@hadrien">
<pre class="moz-quote-pre" wrap="">
julia
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">
Signed-off-by: Alaa Mohamed <a class="moz-txt-link-rfc2396E" href="mailto:eng.alaamohamedsoliman.am@gmail.com"><eng.alaamohamedsoliman.am@gmail.com></a>
---
changes in V2:
fix kunmap_local path value to take address of the mapped page.
---
changes in V3:
edit commit message to be clearer
---
drivers/net/ethernet/intel/igb/igb_ethtool.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/igb/igb_ethtool.c b/drivers/net/ethernet/intel/igb/igb_ethtool.c
index 2a5782063f4c..c14fc871dd41 100644
--- a/drivers/net/ethernet/intel/igb/igb_ethtool.c
+++ b/drivers/net/ethernet/intel/igb/igb_ethtool.c
@@ -1798,14 +1798,14 @@ static int igb_check_lbtest_frame(struct igb_rx_buffer *rx_buffer,
frame_size >>= 1;
- data = kmap(rx_buffer->page);
+ data = kmap_local_page(rx_buffer->page);
if (data[3] != 0xFF ||
data[frame_size + 10] != 0xBE ||
data[frame_size + 12] != 0xAF)
match = false;
- kunmap(rx_buffer->page);
+ kunmap_local(data);
return match;
}
--
2.35.2
</pre>
</blockquote>
</blockquote>
</body>
</html>