[darcs-devel] darcs.cgi and annotate on renamed files

[David Roundy]

On Thu, Oct 21, 2004 at 02:51:41PM -0700, Will wrote:
> David Roundy <droundy at abridgegame.org> writes:
> 
> > Actually, it turns out that this is cheap.  When you call changes on a
> > specific file, it has to read all the patches anyways, to see if they
> > modify that file.  I've added a created_as node to the output, but the
> > darcs.cgi doesn't yet seem to recognize this.  Alas, I looked at the
> > changes you made, and it vaguely seems like this ought to "just work", but
> > it doesn't.  :(
> 
> No worries, I hadn't yet added the code to use <created_as/> to
> patches.xslt, only to annotate.xslt.  I've submitted a new patch,
> and the darcs.cgi patch list page now works much better for files that
> have been renamed.

Ah, that would explain it! That's what I get for trying to read xslt
files... :) Looks great!

> One remaining nit is that you still cannot annotate a file while
> specifying the patch that removed the file:

Thanks for noticing this! It was an easy enough fix.  The problem was in my
check whether the file still exists--an off-by-one error.
-- 
David Roundy
http://www.abridgegame.org