[darcs-devel] darcs patch: Replace my_memrchr() with strrchr().

David Roundy droundy at abridgegame.org
Mon Apr 18 06:28:41 PDT 2005


On Mon, Apr 18, 2005 at 09:05:57AM -0400, Ralph Corderoy wrote:
> Sun Apr 17 23:05:34 BST 2005  Ralph Corderoy <ralph at inputplus.co.uk>
>   * Replace my_memrchr() with strrchr().
>   Given it's only ever called on a string, not an arbitrary lump of
>   memory, my_memrchr() can be replaced with strrchr() which is in
>   <string.h>.

I don't think we want to require that this always be called with a string,
so I'd rather keep the my_memrchr.  If my_memrchr is slower than an
optimized version, we could easily add configure checks and use the real
thing if it's available.
-- 
David Roundy




More information about the darcs-devel mailing list