[darcs-devel] darcs patch: Rewrite gcau, and add explanatory comment from David

[Ian Lynagh]

Hi David,

How does this look?

Also, I'm a bit confused; it's not necessarily true that the
(fst $ last ps1) == (fst $ last ps2) test be when the lengths are equal,
right? So we might miss it due to our length equalising if we are
unlucky?

Perhaps we should really be checking lasts each time we take a
new patch set against all lasts on the other side we have seen?

And possibly biasing the search towards the non-network or less-partial
repo (although partialness isn't a total order, I don't think)?

Hmm, just realised my gcau_simple (cr ps1 ++ concat ps1s) (cr ps2)
(and symmetric) case will be missing opportunities to do the test but
aborting sending at this point is too much hassle  :-)


Thanks
Ian

Sat Aug 27 23:49:52 BST 2005  Ian Lynagh <igloo at earth.li>
  * Rewrite gcau, and add explanatory comment from David

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: text/x-darcs-patch
Size: 39181 bytes
Desc: A darcs patch for your repository!
Url : http://lists.osuosl.org/pipermail/darcs-devel/attachments/20050828/9646edf7/attachment.bin